Skip to content

feat: add credential-level option to disable session recording and logging #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snkrheadz wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

feat: add credential-level option to disable session recording and logging #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions credentials/BrowserbaseApi.credentials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,20 @@ export class BrowserbaseApi implements ICredentialType {
required: false,
description: 'Optional. Provide your own model API key, or leave blank to use the <a href="https://docs.browserbase.com/platform/model-gateway/overview">Browserbase Model Gateway</a>.',
},
{
displayName: 'Disable Session Recording',
name: 'disableSessionRecording',
type: 'boolean',
default: false,
description: 'Whether to force-disable session recording for all workflows using this credential. When enabled, the per-node "Record Session" option is ignored and recording is always off.',
},
{
displayName: 'Disable Session Logging',
name: 'disableSessionLogging',
type: 'boolean',
default: false,
description: 'Whether to force-disable session logging for all workflows using this credential. When enabled, the per-node "Log Session" option is ignored and logging is always off.',
},
];

authenticate: IAuthenticateGeneric = {
Expand Down
8 changes: 6 additions & 2 deletions nodes/Browserbase/Browserbase.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,11 +817,15 @@ export class Browserbase implements INodeType {
try {
// 1. Start session
const browserSettings: Record<string, unknown> = {
recordSession: browserOptions.recordSession ?? true,
recordSession: credentials.disableSessionRecording
? false
: (browserOptions.recordSession ?? true),
solveCaptchas: browserOptions.solveCaptchas ?? false,
blockAds: browserOptions.blockAds ?? true,
advancedStealth: browserOptions.advancedStealth ?? false,
logSession: browserOptions.logSession ?? true,
logSession: credentials.disableSessionLogging
? false
: (browserOptions.logSession ?? true),
viewport: {
width: browserOptions.viewportWidth ?? 1288,
height: browserOptions.viewportHeight ?? 711,
Expand Down