fix: n8n review feedback (codex fields, homepage, provenance auth)#14
Merged
Kylejeong2 merged 3 commits intomainfrom Apr 27, 2026
Conversation
shrey150
requested changes
Apr 27, 2026
shrey150
left a comment
There was a problem hiding this comment.
Can you verify / pattern match the publish CI flow here? Not sure we shouldn't be including an NPM token if we're using provenance
| - run: npm run build | ||
| - run: npm publish --provenance --access public | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
If we're using provenance, we don't need an auth token. see example here: https://github.com/browserbase/openclaw-browserbase/blob/0e38ccb01ed8a762f9bb8715a7291bbc301155cb/.github/workflows/release.yml
shrey150
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses blocking issues from n8n Community Engineering review of v1.2.3.
Changes
subcategoriesandn8nNodesApiVersionfields fromnodes/Browserbase/Browserbase.node.json. Onlynode,nodeVersion,codexVersion,categories,resources,aliasare recognized by n8n.homepagefield tohttps://github.com/browserbase/n8n-node.NODE_AUTH_TOKENenv var on thenpm publish --provenancestep in.github/workflows/publish.yml. Without it, the publish either fails auth or falls back to manual publishing (which is why v1.2.3 shipped without an attestation). Provenance becomes mandatory for verified community nodes May 1st 2026.requireCleanWorkingDir: trueto.release-it.jsonso release-it refuses to tag when there are uncommitted changes. Combined with runningnpm run releaseonly frommain(never a feature branch), this prevents the recurring bug where git tags point to commits that don't match the publishedpackage.jsonversion.