Skip to content

fix: n8n review feedback (codex fields, homepage, provenance auth)#14

Merged
Kylejeong2 merged 3 commits intomainfrom
kylejeong/gro-1310-update-n8n-nodes-browserbase-for-cloud-verification-codex
Apr 27, 2026
Merged

fix: n8n review feedback (codex fields, homepage, provenance auth)#14
Kylejeong2 merged 3 commits intomainfrom
kylejeong/gro-1310-update-n8n-nodes-browserbase-for-cloud-verification-codex

Conversation

@Kylejeong2
Copy link
Copy Markdown
Member

Summary

Addresses blocking issues from n8n Community Engineering review of v1.2.3.

Changes

  • [MEDIUM] Codex file — removed unsupported subcategories and n8nNodesApiVersion fields from nodes/Browserbase/Browserbase.node.json. Only node, nodeVersion, codexVersion, categories, resources, alias are recognized by n8n.
  • [LOW] package.json — set empty homepage field to https://github.com/browserbase/n8n-node.
  • [LOW] npm provenance — added missing NODE_AUTH_TOKEN env var on the npm publish --provenance step in .github/workflows/publish.yml. Without it, the publish either fails auth or falls back to manual publishing (which is why v1.2.3 shipped without an attestation). Provenance becomes mandatory for verified community nodes May 1st 2026.
  • [Note] Tag/version mismatch — added requireCleanWorkingDir: true to .release-it.json so release-it refuses to tag when there are uncommitted changes. Combined with running npm run release only from main (never a feature branch), this prevents the recurring bug where git tags point to commits that don't match the published package.json version.

Copy link
Copy Markdown

@shrey150 shrey150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify / pattern match the publish CI flow here? Not sure we shouldn't be including an NPM token if we're using provenance

Comment thread .github/workflows/publish.yml Outdated
- run: npm run build
- run: npm publish --provenance --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kylejeong2 Kylejeong2 requested a review from shrey150 April 27, 2026 22:52
@Kylejeong2 Kylejeong2 merged commit d2cf382 into main Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants