fix(server-v4): accept expect* options on /v4/page/click

[BABTUNA]

why

/v4/page/click still had a schema TODO for click expectation flags and rejected payloads containing expectDownload, expectNavigation, or expectPopup.

Closes #2051.

what changed

• Updated PageClickParamsSchema to accept optional booleans:
  • expectDownload
  • expectNavigation
  • expectPopup
• Added integration coverage in page.test.ts to assert /v4/page/click accepts expect* options.
• Regenerated packages/server-v4/openapi.v4.yaml so the new click params are documented.

validation

• npm.cmd exec prettier -- --write packages/server-v4/src/schemas/v4/page.ts packages/server-v4/test/integration/v4/page.test.ts
• node node_modules/typescript/bin/tsc -p packages/server-v4/tsconfig.json --noEmit
• node --import=tsx -e "...app.inject('/v4/page/click' with expect* params)..." (status 200)
• node --import=tsx packages/server-v4/scripts/gen-openapi.ts

---

Summary by cubic

Updated /v4/page/click to accept expectDownload, expectNavigation, and expectPopup so clients can declare expected side-effects. This fixes rejected payloads and documents the new params.

• Bug Fixes
  • Extended PageClickParamsSchema with optional booleans: expectDownload, expectNavigation, expectPopup.
  • Added integration test to confirm /v4/page/click accepts these options.
  • Regenerated packages/server-v4/openapi.v4.yaml to include the new params.

^{Written for commit dd81cd4. Summary will update on new commits. Review in cubic}

[changeset-bot]

⚠️ No Changeset found

Latest commit: dd81cd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

Architecture diagram

sequenceDiagram
    participant Client as Test/Client
    participant API as API Route (/v4/page/click)
    participant Zod as PageClickParamsSchema
    participant Driver as Browser Automation Driver

    Note over Client,Driver: Page Click Request Flow

    Client->>API: POST /v4/page/click
    Note right of Client: Body: { selector, expectNavigation: true, ... }

    API->>Zod: validate(requestBody)
    
    alt Valid Payload
        Zod-->>API: NEW: Returns params including expectDownload/Navigation/Popup
        API->>Driver: performClick(params)
        Note over Driver: Executes click and waits for<br/>specified side-effects
        Driver-->>API: Success
        API-->>Client: 200 OK
    else Invalid Payload (strict validation)
        Note over Zod: CHANGED: No longer rejects<br/>expect* keys
        Zod-->>API: Validation Error
        API-->>Client: 400 Bad Request
    end

    Note over API,Zod: Schema updated to permit optional booleans<br/>previously marked as TODO.

Loading