Skip to content

feat(split-tabs): add top-bottom split panes#1015

Open
Wei-Cheng Hsu (weicheng-hsu) wants to merge 1 commit into
browseros-ai:mainfrom
weicheng-hsu:feat/top-bottom-split-panes
Open

feat(split-tabs): add top-bottom split panes#1015
Wei-Cheng Hsu (weicheng-hsu) wants to merge 1 commit into
browseros-ai:mainfrom
weicheng-hsu:feat/top-bottom-split-panes

Conversation

@weicheng-hsu
Copy link
Copy Markdown

@weicheng-hsu Wei-Cheng Hsu (weicheng-hsu) commented May 16, 2026

Summary

Adds top/bottom split creation from the split tabs toolbar button context menu.

  • Keeps the existing toolbar left-click behavior unchanged.
  • Adds context menu options for left/right and top/bottom split creation.
  • Adds browser test coverage for the toolbar context menu flow.

Design

This PR adds a layout parameter to the toolbar split creation path and passes it through to the split view UI.

The top/bottom option uses SplitTabLayout::kHorizontal, which MultiContentsView uses to lay out panes vertically and resize them by height ratio. Existing default split
creation paths continue to use the current left/right layout.

Test plan

  • Built BrowserOS locally with full autoninja.
  • Manually verified top/bottom split creation from the toolbar button context menu.
  • Manually verified focus switching and divider resizing for top/bottom panes.

Related to: #928

split_top_bottom_test.mp4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

All contributors have signed the CLA. Thank you!
Posted by the CLA Assistant Lite bot.

@weicheng-hsu
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@weicheng-hsu Wei-Cheng Hsu (weicheng-hsu) force-pushed the feat/top-bottom-split-panes branch 3 times, most recently from abcd0f9 to c25d6dc Compare May 31, 2026 11:26
@weicheng-hsu Wei-Cheng Hsu (weicheng-hsu) marked this pull request as ready for review May 31, 2026 11:45
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 31, 2026

PR author is not in the allowed authors list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant