feat(split-tabs): add top-bottom split panes#1015
Open
Wei-Cheng Hsu (weicheng-hsu) wants to merge 1 commit into
Open
feat(split-tabs): add top-bottom split panes#1015Wei-Cheng Hsu (weicheng-hsu) wants to merge 1 commit into
Wei-Cheng Hsu (weicheng-hsu) wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
abcd0f9 to
c25d6dc
Compare
c25d6dc to
c52d67a
Compare
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds top/bottom split creation from the split tabs toolbar button context menu.
Design
This PR adds a layout parameter to the toolbar split creation path and passes it through to the split view UI.
The top/bottom option uses
SplitTabLayout::kHorizontal, which MultiContentsView uses to lay out panes vertically and resize them by height ratio. Existing default splitcreation paths continue to use the current left/right layout.
Test plan
autoninja.Related to: #928
split_top_bottom_test.mp4