fix(agent): guard runMissedJobs daily branch from premature execution#1019
Open
Akhilesh Arora (akhilesharora) wants to merge 1 commit into
Open
Conversation
A brand-new daily job created today after its scheduleTime fires on the
next startup instead of waiting for tomorrow's alarm. The daily branch
in runMissedJobs only checked whether HH:MM had passed today, not
whether the job existed before that time. Mirror the hourly/minutes
branch immediately below, which already gates on createdAt.
Also guard against scheduleTime values that don't parse as HH:MM
("abc", "", "9"). Without the Number.isFinite check, setHours(NaN, ...)
yields an invalid Date and the gate falls through on every alarm tick.
Reachable via LLM-generated nudges where scheduleTime is unvalidated.
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
All contributors have signed the CLA. Thank you! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runMissedJobswas missing thecreatedAtgate that the hourly/minutes branch right below it already had, so a brand-new daily task fires on the next startup instead of waiting for tomorrow's alarm.Number.isFinitecheck for the parsed hours/minutes, so malformedscheduleTimestrings ("abc","","9") skip instead of falling through with a NaN gate.Design
The daily check at
scheduledJobRuns.ts:176-181only asked "has the scheduled HH:MM passed today?". For a job created today at 17:30 withscheduleTime: "09:00", that's true, so the gate fell through and the task ran immediately, even thoughcreateAlarmFromJobcorrectly scheduled the first alarm for tomorrow 09:00. The hourly/minutes branch right below (lines 183-193) already gates oncreatedAt; mirroring that here closes the daily case.The
Number.isFiniteguard handlesscheduleTimestrings that don't parse cleanly. Without it,setHours(NaN, NaN, ...)yields an invalid Date and the gate always falls through, so a job with a malformed schedule fires on every alarm tick. Reachable viaapps/server/src/tools/nudges.ts, which accepts any string forscheduleTime.Test plan
Daily-gate logic in Node, with the fix applied:
Legitimate missed runs (job created before today's scheduled time, browser was closed across it) still fire as intended.
Fixes #1018