[codex] Clarify bun lockfile detection errors#85
Draft
aouxwoux wants to merge 3 commits into
Draft
Conversation
ai
reviewed
Jul 3, 2026
| process.exit(1) | ||
| } | ||
|
|
||
| let packageManagerIndex = args.indexOf('--package-manager') |
Member
There was a problem hiding this comment.
This part is not very readable. Let’s add getArgValue() helper.
ai
reviewed
Jul 3, 2026
ai
reviewed
Jul 3, 2026
aouxwoux
force-pushed
the
codex/clarify-bun-lockfile-error
branch
from
July 3, 2026 10:17
e124ec2 to
8163aa9
Compare
ai
reviewed
Jul 6, 2026
ai
reviewed
Jul 6, 2026
ai
reviewed
Jul 6, 2026
ai
reviewed
Jul 6, 2026
Author
|
pushed a follow-up for the review notes:
checks passing locally with npm/pnpm shims: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.
What changed
bun.lockb.--package-managerandUPDATE_BROWSERSLIST_DB_PM.bunis not available on PATH.Verification
pnpm unitpnpm test:lintnode cli.js --helpnode cli.js --package-managerexits with the expected missing-value errorNote:
pnpm testreaches the same passing unit/lint steps locally, but Windows skips the existing Yarn/Bun probes because they redirect to/dev/null; CI runs on Ubuntu with Bun installed.