Allow user to override the q-scaler reset - #1605
Merged
Merged
Conversation
erhart1
changed the title
Collaborator
Author
|
FYI @elindgren |
Owner
|
It seems this PR assumed the local (small) model to be fine-tuned is from NEP89, but I will merge it and let extension to be done in the future. @erhart1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
import_q_scalerinput parameter fornep.If set to1theq_scalerwill taken from thenep.txtfile available in the run directory. This allows a user to override the reinitialization of theq_scaleron restart. This behavior is necessary for truthful fine-tuning based on externally provided restart files. Thefine_tunecommand does this already internally.