Changed Ratio type from Int to Double#10
Closed
vens17 wants to merge 1 commit intobrushedtype:mainfrom
vens17:fix-ratio-type
Closed
Changed Ratio type from Int to Double#10vens17 wants to merge 1 commit intobrushedtype:mainfrom vens17:fix-ratio-type
vens17 wants to merge 1 commit intobrushedtype:mainfrom
vens17:fix-ratio-type
Conversation
Member
Author
|
Good day!
I have put “Signed-off-by” on my pull request
#12
…On Fri, Oct 6, 2023 at 7:54 PM Ed Wellbrook ***@***.***> wrote:
Hi @vens17 <https://github.com/vens17>. Thank you for your PR.
Please sign off your commit to acknowledge agreement with the DCO
<https://github.com/brushedtype/Ratios/blob/main/CONTRIBUTING.md>.
Example (see “Signed-off-by” in the commit message): 8295ef9
<8295ef9>
Once that’s done, please reply to let me know and I’ll merge.
Thanks!
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE5OVFGVVN4JAZUHJS6FZSTX57WQHAVCNFSM6AAAAAA5TLWUFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGUYTIMZWGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.