[Issue 180] Fix python2 x python3 incompatibility#225
[Issue 180] Fix python2 x python3 incompatibility#225almostimplemented wants to merge 2 commits intobrutasse:masterfrom
Conversation
|
Would it be possible to add a regression test? I'm not sure which conditions triggers this issue. |
|
Sure, added. The condition to trigger is when the operands of the compare in |
| ("127.0.0.1",None) | ||
| ] | ||
| carbonlink = ConsistentHashRing(hosts) | ||
| node = carbonlink.get_node('hosts.worker44.cpu') |
There was a problem hiding this comment.
Hm, it looks like this passed the automated test... I arrived upon this value by iterating through metric values (e.g. for x in range(100): ... 'hosts.worker%s.cpu' % x ... ). This was the first value triggering the raised bisect exception.
253492d to
635b42b
Compare
|
This seems to work for me. |
Addresses bug #180 encountered when running Graphite in Python 3.