Skip to content

Fix SDK path on windows runners #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vcolomer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix SDK path on windows runners #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

27 changes: 23 additions & 4 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const core = require('@actions/core')
const { mkdir, cp, readFile } = require('node:fs/promises')
const { mkdir, cp, readFile, readdir } = require('node:fs/promises')
const { resolve, join } = require('node:path')
const { platform } = require('node:os')
const { execSync } = require('node:child_process')
Expand Down Expand Up @@ -41,9 +41,28 @@ async function run() {

// remove existing code signature on node binary
if (os === 'win32') {
const signtool =
'%programfiles(x86)%/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe'
execSync(`"${signtool}" remove /s ${nodeDest}`)
const sdkDir = join(
process.env['ProgramFiles(x86)'],
'Windows Kits',
'10',
'bin'
)

const sdkVersions = (await readdir(sdkDir)).filter(f =>
f.startsWith('10.0.')
)

if (!sdkVersions.length)
throw new Error(
`No Windows 10 SDK version starting with 10.0. found under '${sdkDir}'`
)

// Get latest version
const sdkVersion = sdkVersions[sdkVersions.length - 1]

const signtoolExecutable = join(sdkDir, sdkVersion, 'x86', 'signtool.exe')

execSync(`"${signtoolExecutable}" remove /s ${nodeDest}`)
} else if (os === 'darwin') {
execSync(`codesign --remove-signature ${nodeDest}`)
}
Expand Down