Skip to content

Fix flexible array members in event_t, HWC_Set_t #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hainest wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flexible array members in event_t, HWC_Set_t #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/common/record.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ typedef struct
u_param param; /* Parameters of this event */
UINT64 value; /* Value of this event */
UINT64 time; /* Timestamp of this event */
#if 1 || USE_HARDWARE_COUNTERS || defined(HETEROGENEOUS_SUPPORT)
long long HWCValues[MAX_HWC]; /* Hardware counters read for this event */
#endif
INT32 event; /* Type of this event */
#if 1 || USE_HARDWARE_COUNTERS || defined(HETEROGENEOUS_SUPPORT)
INT32 HWCReadSet; /* Marks which set of counters was read, if any */
#endif
#if 1 || USE_HARDWARE_COUNTERS || defined(HETEROGENEOUS_SUPPORT)
long long HWCValues[MAX_HWC]; /* Hardware counters read for this event */
#endif
} event_t;


Expand Down
2 changes: 1 addition & 1 deletion src/tracer/hwc/common_hwc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ struct HWC_Set_t
pm_prog_t pmprog;
int group;
#endif
int counters[MAX_HWC];
int num_counters;
unsigned long long change_at;
enum ChangeType_t change_type;
Expand All @@ -51,6 +50,7 @@ struct HWC_Set_t
int *OverflowCounter;
int NumOverflows;
#endif
int counters[MAX_HWC];
};

// Define a safe default if PAPI is not available
Expand Down