Show lazy-skipped nodes as 'skipped' (fix stuck-on-running)#181
Merged
Conversation
The runtime emits node_skipped for lazy-skipped nodes (PR #175), but the UI's state machine had no case for that event, so the prior node_started left the node stuck at status='running' forever. Visible whenever you tweak a downstream node and the upstream chain stays cached: the early steps animated as 'running' for the lifetime of the page. Add a new 'skipped' NodeStatus rather than reusing 'cached'. The two are semantically different — cached entries have files on disk that the preview pane can load; skipped entries don't, because the runtime decided no downstream consumer would read them. Conflating the two would make the preview pane attempt to load an image that isn't there. Backend EventType union also picks up the long-missing node_skipped and node_warning literals so the cast in _emit_event matches reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a follow-up to #175. The runtime emits `node_skipped` for lazy-skipped nodes, but the UI state machine had no case for it, so the prior `node_started` left the node stuck on `status='running'` indefinitely. Now visible any time you tweak a downstream node and the upstream chain stays cached.
Test plan