Serve full-resolution PNG output (fix 'Open full' giving a 512px thumbnail)#183
Merged
Conversation
The 'Open full' affordance on the terminal node linked to /api/preview,
which thumbnailed every artifact (PNG and FITS alike) to 512px. The
save_image node produces a full-resolution PNG via Siril's `savepng`,
but the UI never had a way to fetch it -- users opened the link and
got a tiny version of their multi-megapixel export.
New /api/output/<node_hash>/<port> endpoint serves the actual artifact:
- PNG outputs: the committed file is returned as-is. No re-encode,
no thumbnail. The 6000x4000 save_image export survives intact.
- FITS outputs: autostretched at full resolution and cached inside
the entry as _output_<port>.png. Subsequent opens are a file read.
Cache filenames are namespaced (_preview_*.png vs _output_*.png) so
the in-page thumbnail and the full-res render coexist in one entry.
UI: api.outputUrl() mirrors previewUrl/previewUrlStretched. PipelineRow's
'Open full' button now points at it. The tile thumbnail still uses
previewUrl().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Open full" affordance on the terminal node linked to `/api/preview`, which thumbnails every artifact (PNG and FITS alike) to `THUMB_LONG_EDGE = 512` px. The `save_image` node writes a full-resolution PNG via Siril's `savepng`, but the UI never had a way to fetch it — users opened the link and got a tiny version of their multi-megapixel export.
Shape
Test plan