Bundle GraXpert AI models into Docker image#185
Merged
Conversation
overflow-x: auto implicitly enables overflow-y: auto per spec, producing a spurious vertical scrollbar. Clamp it to hidden. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GraXpert downloads its onnxruntime models (~700 MB total) via a private Minio bucket on first use. In a container these downloads can fail silently partway through: the partial zip leaves a non-empty directory, which tricks list_local_versions() into thinking the model is installed, and the next job crashes with onnxruntime NoSuchFile on model.onnx. Add a RUN step in the runtime stage that warms both downloads at build time by running GraXpert against a tiny synthetic FITS. The Minio download completes inside get_ai_version() before inference starts, so inference failures on the 64×64 image are expected and silenced. A final 'ls' fails the build loudly if either model.onnx is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.miniofile in the version directorylist_local_versions()only checks that the directory is non-empty, so it thinks the model is installed and skips re-downloadingonnxruntime NoSuchFile: model.onnxFix: add a
RUNstep to theruntimestage that pre-downloads both models during image build by running GraXpert against a minimal synthetic FITS. The Minio download completes insideget_ai_version()before inference starts, so inference failures on the 64×64 image are expected and silenced with|| true. A finallsfails the build loudly if eithermodel.onnxis missing.Test plan
docker build --build-arg BASE=nvidia/cuda:12.4.1-runtime-ubuntu22.04 ...) and confirm the build log shows GraXpert downloading models and the finallsprints bothmodel.onnxpathsonnxruntime NoSuchFileerror