Potential fix for code scanning alert no. 5: Size computation for allocation may overflow#2
Draft
bsdrop wants to merge 2 commits into
Draft
Potential fix for code scanning alert no. 5: Size computation for allocation may overflow#2bsdrop wants to merge 2 commits into
bsdrop wants to merge 2 commits into
Conversation
…ocation may overflow Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… allocation may overflow' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bsdrop/lafdb/security/code-scanning/5
To fix this safely without changing functionality, compute the combined capacity once with an overflow guard before using it in
make. In Go, the standard pattern is:if a > math.MaxInt-bbeforea+bBest concrete fix here:
internal/scraper/modified.go, importmath.buildModifiedEvents, before allocations on lines currently usinglen(oldMap)+len(newMap), add:oldLen := len(oldMap)newLen := len(newMap)math.MaxIntcombinedLen := oldLen + newLencombinedLenfor bothidsandseencapacities.fmt.Errorf) if overflow is detected.This addresses all three alert variants because they all flow into the same vulnerable sink in
buildModifiedEvents.Suggested fixes powered by Copilot Autofix. Review carefully before merging.