Potential fix for code scanning alert no. 4: Size computation for allocation may overflow#3
Draft
bsdrop wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 4: Size computation for allocation may overflow#3bsdrop wants to merge 1 commit into
bsdrop wants to merge 1 commit into
Conversation
…ocation may overflow Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if oldLen > maxInt-newLen { | ||
| return nil, fmt.Errorf("too many tracked items") | ||
| } | ||
| total := oldLen + newLen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bsdrop/lafdb/security/code-scanning/4
Add an explicit overflow guard before computing combined capacity in
buildModifiedEvents(internal/scraper/modified.go), and only performlen(oldMap)+len(newMap)after validating it cannot exceedintmax. In Go, a clean approach is:oldLen := len(oldMap),newLen := len(newMap).if oldLen > int(^uint(0)>>1)-newLen { return nil, fmt.Errorf("...") }.total := oldLen + newLenfor bothidsandseenpreallocation.This preserves behavior for normal inputs while preventing overflow panic/wraparound. No new dependency is needed;
fmtis already imported in the shown file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.