Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Currently the user is not able to provide their own response for unmocked incoming requests – the only option is a hardcoded 404 and passthrough to real network.
The changes in this PR adds these two cases to
UnmockPolicy:.mock(MockResponse).fatalErrorUnmockedPolicy.mock(MockResponse)This one lets the user provide their own
MockResponsefor all unmocked requests. The single response will be used for all incoming requests where a mock can't be found – either because none is registered, or the queue is empty.UnmockedPolicy.fatalErrorThis is an addition for stricter testing which will call
fatalError()if there aren't any mocks for an incoming request. Usecases will be to i.e. create a hard assumption that all network requests are mocked or handled.Closes #7
What?
.mock(MockResponse)and.fatalErrortoUnmockedPolicy.HTTPURLMockProtocol.Show me