Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We currently only supports exact string matching for host and path patterns, which limits flexibility when it comes to either reuse the same mock for dynamic URLs, having a versionated API and/or environment specific subdomains. Currently the user will have to register each of these variations individually, which causes a lot of overhead and unnecessary maintenance.
How?
This PR adds wildcard pattern matching using glob-style syntax for segments in either/or host or path. A segment for a host is the content between two
., a segment for a path is the content between two/.*): match within one segment only.**): match across multiple segments (zero or more).HTTPMockinstances.What?
HTTPMockMatcher.HTTPMockMatcher.ExpressionStorage.Show me
Single segment wildcards
Matches:
api.example.com/api/v1/greetingstaging.example.com/api/v2/greetingDoesn't match:
api.staging.example.com/api/v1/beta/greetingMulti-segment wildcards
Matches:
api.example.com/api/dataapi.staging.example.com/api/v1/beta/dataAutomatic specificity ranking
Given patterns:
api.example.com*.example.com**.example.comResult: Chooses exact match
api.example.com(exact match, aka. highest priority)Complex patterns with multiple wildcards
Matches:
api-staging.example.com/api/v1-test/users