Add main field to package.json#216
Merged
Merged
Conversation
The lack of `main` field throws off TypeScript when used with the `node` resolution[^1], as well as eslint-plugin-import's module resolution through the `resolve` package, which does not support ESM yet[^2]. [^1]: https://www.typescriptlang.org/docs/handbook/modules/reference.html#node10-formerly-known-as-node [^2]: browserify/resolve#222
Owner
|
Thank you |
Owner
|
Released as 7.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While Node itself is happy with only an
exportsfield inpackage.json, it doesn't seem enough for some tooling packages. The lack ofmainfield:nodemoduleResolutioneslint-plugin-import's module resolution through theresolvepackage, which does not support ESM yet.There may also be other tools implementing their own module resolution which won't cope with having only
exports. It'd be great ifrollup-plugin-visualizerwas offering a fallbackmainfield in its package.json, as described in Node's documentation.