Merged
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…on (#148) Create ofsc/async_client/_base.py with AsyncClientBase and ofsc/async_client/_protocols.py with shared _CoreBaseProtocol. All 5 async modules now inherit from AsyncClientBase, removing ~400 lines of duplicated __init__, config, baseUrl, headers, _parse_error_response, and _handle_http_error boilerplate. core/resources.py and core/users.py import _CoreBaseProtocol from the shared _protocols.py instead of defining it locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tadata.py (#116) Add 8 generic helper methods to AsyncClientBase (_clean_response, _get_paginated_list, _get_single_item, _get_all_items, _put_item, _post_item, _patch_item, _delete_item) and refactor ~65 of 91 methods in async metadata.py to delegate to them, reducing the file by ~674 lines (~22%). Also fixes two bugs: - Missing quote_plus URL encoding in get_property, get_workzone, create_or_replace_property, update_property - Inconsistent 'links' removal across 55 methods, now unified via _clean_response() Adds 32 new unit tests in tests/async/test_async_base_helpers.py. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add HELPER_METHOD_MAP and a second detection pass in scan_file_for_endpoints() to recognize calls to AsyncClientBase helpers (_get_paginated_list, _get_single_item, _put_item, etc.). This restores correct endpoint detection after the #116 refactor that replaced urljoin() calls with helper delegation — async metadata now shows 85 endpoints instead of 22. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.24.3
Changes
AsyncClientBaseto eliminate cross-module duplication (Closes Extract shared AsyncClientBase to eliminate cross-module duplication #148)ofsc/async_client/_base.pywith shared error handling and auth headersAsyncClientBase(~400 duplicated lines removed)ofsc/async_client/_protocols.pyAsyncClientBaseand refactormetadata.py(Closes Refactor async metadata.py to reduce code duplication with helper methods #116)_get_paginated_list,_get_single_item,_get_all_items,_put_item,_post_item,_patch_item,_delete_item,_clean_response)quote_plusURL encoding inget_property,get_workzone,create_or_replace_property,update_propertylinksremoval across 55 methods, now unified via_clean_response()tests/async/test_async_base_helpers.pyResourceCreateandUserCreatedocs/patternsto.gitignoreChecklist