Open
Conversation
- there is no domain reload between tests - the SaveManager stores state in a singleton, so it only resets on domain reload - there is no way to deregister a saveable if it is destroyed
improve async -> coroutine by reading the UniTask library source code
…atible with running on different threads. instead relying on C# System.Threading.Tasks
… unity json converters
organize test files. extract a shared function to a base test class add some documentation to the tests
fixup the unity converter test based on real functionality
…essary, Singleton will auto-create
…when using unity converters
Add doc comments to some test methods
…t need a custom to-coroutine converter: https://docs.unity3d.com/6000.0/Documentation/Manual/AwaitSupport.html
Member
|
@dsmiller95 I completely missed this PR! Sorry for the slow response, I'll take a look soon and write more. Thanks so much for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests which:
The project used to develop these changes is here: https://github.com/dsmiller95/SaveAsyncEditingProject . Most tests will run in a fresh project, but to see the json-for-unity tests, the development project must also install the json-for-unity (and leave it at default settings).
These tests uncovered one potential issue, documented in #2