ci: fix correct secret names passed to reusable e2e workflow#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix https://github.com/bucketeer-io/node-server-sdk/actions/runs/26619299937
Error
The error was first seen in https://github.com/bucketeer-io/node-server-sdk/actions/runs/19558608373
Problem
The build.yml caller workflow was passing secrets under the wrong keys when invoking the reusable e2e.yml workflow:
This happened because the secrets block in build.yml used legacy/inconsistent names (
E2E_HOST,E2E_TOKEN,E2E_SERVER_ROLE_TOKEN) that do not match thesecrets:declarations in e2e.yml. GitHub Actions validates secret names at parse time forworkflow_call, so the workflow was rejected before any job ran.Fix
Updated the
secretsblock in the e2e job of build.yml to pass the correct keys that match the reusable workflow's declared interface:E2E_HOSTE2E_API_ENDPOINTE2E_TOKENE2E_CLIENT_API_KEYE2E_SERVER_ROLE_TOKENE2E_SERVER_API_KEYNo changes were made to e2e.yml — it was already correct.