Skip to content

ci: fix correct secret names passed to reusable e2e workflow#209

Merged
cre8ivejp merged 1 commit into
masterfrom
fix/build-work-flow
May 29, 2026
Merged

ci: fix correct secret names passed to reusable e2e workflow#209
cre8ivejp merged 1 commit into
masterfrom
fix/build-work-flow

Conversation

@duyhungtnn
Copy link
Copy Markdown
Collaborator

@duyhungtnn duyhungtnn commented May 29, 2026

fix https://github.com/bucketeer-io/node-server-sdk/actions/runs/26619299937

Error

The workflow is not valid. .github/workflows/build.yml (Line: 126, Col: 11): Secret E2E_API_ENDPOINT is required, but not provided while calling. .github/workflows/build.yml (Line: 126, Col: 11): Secret E2E_CLIENT_API_KEY is required, but not provided while calling.

The error was first seen in https://github.com/bucketeer-io/node-server-sdk/actions/runs/19558608373

Problem

The build.yml caller workflow was passing secrets under the wrong keys when invoking the reusable e2e.yml workflow:

Secret E2E_API_ENDPOINT is required, but not provided while calling.
Secret E2E_CLIENT_API_KEY is required, but not provided while calling.

This happened because the secrets block in build.yml used legacy/inconsistent names (E2E_HOST, E2E_TOKEN, E2E_SERVER_ROLE_TOKEN) that do not match the secrets: declarations in e2e.yml. GitHub Actions validates secret names at parse time for workflow_call, so the workflow was rejected before any job ran.

Fix

Updated the secrets block in the e2e job of build.yml to pass the correct keys that match the reusable workflow's declared interface:

Before After
E2E_HOST E2E_API_ENDPOINT
E2E_TOKEN E2E_CLIENT_API_KEY
E2E_SERVER_ROLE_TOKEN E2E_SERVER_API_KEY

No changes were made to e2e.yml — it was already correct.

@duyhungtnn duyhungtnn marked this pull request as ready for review May 29, 2026 07:51
@duyhungtnn duyhungtnn requested a review from cre8ivejp as a code owner May 29, 2026 07:51
@cre8ivejp cre8ivejp changed the title fix: correct secret names passed to reusable e2e workflow ci: fix correct secret names passed to reusable e2e workflow May 29, 2026
Copy link
Copy Markdown
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cre8ivejp cre8ivejp merged commit 6af2d44 into master May 29, 2026
15 checks passed
@cre8ivejp cre8ivejp deleted the fix/build-work-flow branch May 29, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants