Fix reading files larger than 2GiB on macOS#3
Open
stuart8c wants to merge 2 commits intobuergmann:mainfrom
Open
Fix reading files larger than 2GiB on macOS#3stuart8c wants to merge 2 commits intobuergmann:mainfrom
stuart8c wants to merge 2 commits intobuergmann:mainfrom
Conversation
added 2 commits
April 13, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read()returns EINVAL when count > INT_MAX. For files >2GiB,read_to_end()passed the full file size in a single call which silently failed. The uninitialised malloced buffer was displayed (usually all 00 bytes) with no error message.read()call to 0x7FFF0000 bytes (to accommodate Linux and macOS), looping for the remainder.read_to_end()fails exit withperror()instead of callingsysemsg()which gets immediately painted over byrepaint().