refactor(build): promote task-metrics, self-check, env-vault to always-on#3661
Merged
Conversation
…s-on Remove three lightweight feature flags that were already in the default build and have zero or trivial external dependencies. This eliminates three feature propagation chains and ~43 #[cfg] annotations across the workspace. Changes: - task-metrics: removed from zeph-common, zeph-core; cpu-time and metrics deps are now non-optional - self-check: removed from zeph-agent-context, zeph-core; quality pipeline always compiled - env-vault: removed from zeph-vault, zeph-core; EnvVaultProvider always compiled - default simplified from 5 flags to ["scheduler", "sqlite"] - full now includes sqlite explicitly (was implicit via default) - specs 001, 029, 039, 046, 049 updated to reflect always-on status BREAKING CHANGE: the env-vault, self-check, and task-metrics feature flags are removed from all published crates. Downstream consumers must remove these flags from their Cargo.toml dependencies. Closes #3659
github-actions
Bot
added
documentation
github-actions
Bot
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task-metrics,self-check,env-vaultdefaultfrom 5 flags to["scheduler", "sqlite"]sqliteexplicitly tofull(was relying ondefault)#[cfg]annotations and 3 stale doc-commentsAnalysis
Full feature-by-feature analysis performed before implementation:
task-metrics: 2 lightweight deps (cpu-time, metrics) already in default; zero functional changeself-check: zero external deps, 8 cfg sites, pure quality pipeline codeenv-vault: zero external deps,EnvVaultProvideris a ~25-line env-var reader always safe to compileBreaking changes
The
env-vault,self-check, andtask-metricsfeature flags are removed fromzeph-vault,zeph-core,zeph-agent-context, andzeph-common. Downstream consumers must remove these flags from theirCargo.toml.Test plan
cargo nextest run --workspace --lib --bins— 8934 tests passcargo nextest run --workspace --lib --bins --features full— 9327 tests passcargo +nightly fmt --checkcleancargo clippy --workspace --lib --bins -- -D warningscleancargo deny check advisoriesclean (1 pre-existing RUSTSEC-2025-0134 in ignore list)Closes #3659