Draft
Conversation
RawSlots operate purely on unprotecetd indices, Slots gives all the protection around it.
Contributor
Author
|
(Plus this will need some changes to account for the last weeks; I had forgotten to push this right away). |
Owner
|
Thanks for your continued interest in this project :) Before progressing forward on this front, I think we should first stabilize the split-up unrestricted and "normal" structures (I've redone #11 on top of the latest changes, I'll add iter_mut() and clean up the implementation before merging). For SlotMap I think there is no reason to try to be clever instead of storing the generation in a different word than the index itself. I'd personally take the performance over some extra bytes of memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #11, this is adding a SlotMap implentation.
It is built for the embedded use case (where the number of slots can be counted with a few bits), and packs the generation in the high bits of the key (so access should be a plain mask, get, compare).
I'm not happy yet with the performance -- manipulation is a lot slower than to the plain RawSlots, and I couldn't yet figure out why.