fix(vnc): start VNC server on boot and correct noVNC port from 4200 to 9020#44
Open
tejas0077 wants to merge 4 commits intobugbasesecurity:mainfrom
Open
fix(vnc): start VNC server on boot and correct noVNC port from 4200 to 9020#44tejas0077 wants to merge 4 commits intobugbasesecurity:mainfrom
tejas0077 wants to merge 4 commits intobugbasesecurity:mainfrom
Conversation
added 3 commits
March 14, 2026 15:53
Signed-off-by: Tejas Saubhage <tsaubhage0007@gmail.com>
Signed-off-by: Tejas Saubhage <tsaubhage0007@gmail.com>
…o 9020 Fixes bugbasesecurity#41 - Add Xvnc startup on DISPLAY=:89 (port 5989) to entrypoint.sh - Add XFCE desktop session startup on DISPLAY=:89 - Add websockify proxy startup (port 9020 -> localhost:5989) - Fix run.sh noVNC URL from port 4200 to 9020 (4200 is shellinabox)
Collaborator
|
Hi @tejas0077 Two things in this PR:
Please update your PR with these fixes. |
Contributor
Author
|
Hi @Hackerbone, I have addressed both your review comments: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Description
Two bugs were causing noVNC to fail in the Kali container:
VNC server never started — entrypoint.sh installed Xvnc via the Dockerfile but never launched it on container startup.
Websockify was running but had nothing to proxy to (port 5989 was not listening).
Wrong port in run.sh — run.sh displayed the noVNC URL as http://localhost:4200/ which is actually the shellinabox port.
noVNC runs on port 9020.
Changes Made
kali/entrypoint.sh: Added Xvnc startup on DISPLAY=:89 (port 5989), XFCE desktop session, and websockify proxy (port 9020 to localhost:5989)
run.sh: Fixed noVNC URL from port 4200 to 9020 (lines 1063 and 1326)
Type of Change
Bug fix (non-breaking change that fixes an issue)
Related Issues
Fixes #41
Testing
Manual testing performed.
Verified entrypoint.sh correctly starts Xvnc, XFCE, and websockify in sequence.
Verified run.sh now shows correct noVNC port 9020.
Checklist
My code follows the project's style guidelines.
I have performed a self-review of my code.
My changes generate no new warnings.