Align sidebar channel icons with the server icon column#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chevron(12) + spacing(6) = 18ptbefore their icon, while channel rows hadpadding(.leading, 12). So the antenna icon sat 6pt to the right of the channels' hash/person icons, making the column read as staggered.Changes
Sources/Brygga/Views/ContentView.swift—.padding(.leading, 12)→.padding(.leading, 18)on the per-channelChannelRowinside the server'sForEach. Comment in source explains the math.Test plan
swift build— passesswift test— 132 tests pass (no test changes; pure layout)swiftformat --lint .— cleanRisk / rollback