Mongo breadcrumb: Do not mask filter value nil#801
Open
johnnyshields wants to merge 6 commits intobugsnag:masterfrom
Open
Mongo breadcrumb: Do not mask filter value nil#801johnnyshields wants to merge 6 commits intobugsnag:masterfrom
johnnyshields wants to merge 6 commits intobugsnag:masterfrom
Conversation
Contributor
|
Thanks for raising this. Along with the other PRs you have put forward, we will take a look at this when time allows. |
mclack
added
feature request
…er-do-not-mask-nil
Contributor
Author
|
@mclack and Bugsnag team can you please take a look at my PRs? |
|
This is still on our backlog and we'll be sure to keep you updated once we have an update. Is data leakage an issue that you are facing consistently while using bugsnag-ruby ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
In Mongo queries, the value
nilis a special in that it can impact the behavior of sparse indexes. Rather than masking it with "?" we should indicate that it is nil. There is no risk of this causing data leakage to the logs.Design
This is implemented in the filter masking function.
Changeset
Only changes the Mongo breadcrumb functionality.
This also includes the changes from:
Testing
Tested in RSpec and by TableCheck in production.