Fix for issue #156 - elements of length 75 being ignored#157
Fix for issue #156 - elements of length 75 being ignored#157derekpa wants to merge 3 commits intobuidl-bitcoin:mainfrom
Conversation
|
Thanks for the PR @derekpa. Can you add some tests? |
|
Hi, I added a test with the script mentioned in the bug and ran the tests again to make sure it passed. The code without the fix failed the test as the original issue reported. Is that OK? Should I add anything else? |
|
Can you add a real bitcoin transaction that was previously failing that now parses correctly? |
|
Hi, looking back at the original issue Im now not too sure if bucko13 was just reporting the potential issue for failure because of the code, or was actually coming across unparsable scripts which is what the title implies. Do you have any examples bucko13 ? So other than the example he gave I cant think of a more common script or example that would have an element of exactly 75. |
|
Ooof, sorry. No idea why I missed this ping. It's been a while since I first reported this and don't have a tx offhand. |
Updating the comparison logic so elements of length 75 are included not just less than:
if length <= 75: