Update web sample with dynamic web scaling#646
Open
mike-n-jordan wants to merge 8 commits intobumble-tech:2.xfrom
Open
Update web sample with dynamic web scaling#646mike-n-jordan wants to merge 8 commits intobumble-tech:2.xfrom
mike-n-jordan wants to merge 8 commits intobumble-tech:2.xfrom
Conversation
added 6 commits
January 8, 2024 15:27
# Conflicts: # demos/appyx-navigation/web/src/jsMain/kotlin/com/bumble/appyx/navigation/Main.kt
mike-n-jordan
requested review from
KovalevAndrey and
zsoltk
and removed request for
KovalevAndrey
zsoltk
reviewed
Jan 8, 2024
demos/appyx-navigation/web/src/jsMain/kotlin/com/bumble/appyx/navigation/Main.kt
Outdated
Show resolved
Hide resolved
zsoltk
reviewed
Jan 8, 2024
Comment on lines
142
to
147
| private fun ScreenSize.calculateDensityFromScreenSize(): Density = | ||
| if (widthDp.value < 1500) { | ||
| Density(1.2f, 1f) | ||
| } else { | ||
| Density(1.8f, 1.2f) | ||
| } |
Contributor
There was a problem hiding this comment.
This looks weird to me. Why is it specifically 1500? Why specifically 1.2f, 1f, 1.8f, 1.2f? The issue title also implies dynamic, but this looks more two static cases rather?
| } | ||
|
|
||
| private fun ScreenSize.calculateDensityFromScreenSize(): Density = | ||
| if (widthDp.value < 1500) { |
Collaborator
There was a problem hiding this comment.
should it be a proportional value coerced in (0.75f, 4f)?
added 2 commits
February 20, 2024 13:22
…th_dynamic_web_scaling # Conflicts: # demos/appyx-navigation/web/src/jsMain/kotlin/com/bumble/appyx/navigation/WebTypography.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Have the Appyx navigation demo app scale dynamically for web.