fix(upgrade): ignore benign Homebrew stderr during package upgrades#603
Open
matracey wants to merge 1 commit intoburesdv:mainfrom
Open
fix(upgrade): ignore benign Homebrew stderr during package upgrades#603matracey wants to merge 1 commit intoburesdv:mainfrom
matracey wants to merge 1 commit intoburesdv:mainfrom
Conversation
Homebrew writes progress and status messages (e.g. "✅ Bottle frei0r (2.5.6)") to stderr by design. Cork was treating nearly all stderr output as errors, causing a false "Packages updated with errors" dialog after every successful upgrade. Expand the ignorable stderr pattern list to cover common benign Homebrew output: Bottle, Fetching, Downloading, Pouring, Installing, section headers (==>), success indicators (✅, 🍺), and blank lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Homebrew writes progress and status messages to stderr by design (not just errors). For example, lines like:
✅ Bottle frei0r (2.5.6)==> Downloading ...🍺 /usr/local/Cellar/...Cork treats nearly all stderr output as errors, so every successful upgrade produces a "Packages updated with errors" dialog — even though nothing actually failed.
Fix
Expand the ignorable stderr pattern list in
Update Packages.swiftto cover common benign Homebrew output:BottleFetchingDownloadingAlready downloadedPouringInstalling🍺✅==>The existing
tapandNo checksum defined forpatterns are preserved.Only genuinely unexpected stderr output will now trigger the error dialog.
Notes
✅,🍺) are not language-dependent either.