Skip to content

Release v1.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilmaztayfun merged 2 commits into from
Dec 1, 2025
Merged

Release v1.0 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e2e18
Refactor pagination classes and update namespaces
yilmaztayfun Dec 1, 2025
90b2c5e
Merge pull request #26 from burgan-tech/hateoas-pagination
yilmaztayfun Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions framework/src/BBT.Aether.Application/BBT/Aether/Application/Contracts/IReadOnlyAppService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System.Collections.Generic;
using System.Threading.Tasks;
using BBT.Aether.Application.Dtos;
using BBT.Aether.Domain;
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The using BBT.Aether.Domain; statement is incorrect for resolving the PagedList<T> type, which is used on line 77. PagedList<T> has been moved to a new namespace as part of this refactoring. Please update this to the correct namespace. Based on other changes, this should be BBT.Aether, or preferably BBT.Aether.Pagination if you adopt the suggestion to align namespaces with folder structure.

using BBT.Aether;

using BBT.Aether.Domain.Repositories;

namespace BBT.Aether.Application;
Expand Down
3 changes: 1 addition & 2 deletions ...in/Pagination/IPaginationLinkGenerator.cs → ...re/Pagination/IPaginationLinkGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
using System.Collections.Generic;
using BBT.Aether.Application.Dtos;
using BBT.Aether.Domain.Repositories;

Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file is missing a using statement for the namespace containing the refactored pagination types. Types like PaginationLinks, HateoasPagedList<T>, and PagedList<T> are used in this interface but their namespace is not imported, which will cause a compilation error. You should add a using for BBT.Aether (or BBT.Aether.Pagination if you align namespaces with folder structure).

using BBT.Aether;

namespace BBT.Aether.Domain.Pagination;
namespace BBT.Aether.AspNetCore.Pagination;

/// <summary>
/// Generates HATEOAS pagination links for API responses.
Expand Down
3 changes: 1 addition & 2 deletions ...ain/Pagination/PaginationLinkGenerator.cs → ...ore/Pagination/PaginationLinkGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
using System.Collections.Generic;
using System.Text;
using BBT.Aether.Application.Dtos;
using BBT.Aether.Domain.Repositories;
using Microsoft.AspNetCore.Http;

Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file is missing a using statement for the namespace containing the refactored pagination types. Types like PaginationLinks, HateoasPagedList<T>, and PagedList<T> are used in this class but their namespace is not imported, which will cause a compilation error. You should add a using for BBT.Aether (or BBT.Aether.Pagination if you align namespaces with folder structure).

using BBT.Aether;

namespace BBT.Aether.Domain.Pagination;
namespace BBT.Aether.AspNetCore.Pagination;

/// <summary>
/// Generates HATEOAS pagination links using the current HTTP request context.
Expand Down
2 changes: 1 addition & 1 deletion ...osoft/Extensions/DependencyInjection/AetherAspNetCoreModuleServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System;
using System.IO.Compression;
using System.Linq;
using BBT.Aether.Domain.Pagination;
using BBT.Aether.AspNetCore.ExceptionHandling;
using BBT.Aether.AspNetCore.Pagination;
using BBT.Aether.AspNetCore.Security;
using BBT.Aether.AspNetCore.Tracing;
using BBT.Aether.Users;
Expand Down
2 changes: 1 addition & 1 deletion ...r/Domain/Repositories/HateoasPagedList.cs → ...BBT/Aether/Pagination/HateoasPagedList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.Collections.Generic;

namespace BBT.Aether.Domain.Repositories;
namespace BBT.Aether;
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The namespace BBT.Aether does not align with the file's directory structure, which is BBT.Aether.Core/BBT/Aether/Pagination/. It's a common convention in C# to have namespaces match the folder hierarchy. Consider changing the namespace to BBT.Aether.Pagination for better code organization and discoverability. This would also align with the PR description mentioning a "pagination namespace".

namespace BBT.Aether.Pagination;


/// <summary>
/// Represents a paged list optimized for HATEOAS responses.
Expand Down
2 changes: 1 addition & 1 deletion ...T/Aether/Domain/Repositories/PagedList.cs → ...r.Core/BBT/Aether/Pagination/PagedList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using System.Collections.Generic;

namespace BBT.Aether.Domain.Repositories;
namespace BBT.Aether;
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The namespace BBT.Aether does not align with the file's directory structure, which is BBT.Aether.Core/BBT/Aether/Pagination/. It's a common convention in C# to have namespaces match the folder hierarchy. Consider changing the namespace to BBT.Aether.Pagination for better code organization and discoverability. This would also align with the PR description mentioning a "pagination namespace".

namespace BBT.Aether.Pagination;


/// <summary>
/// Represents a paged list of items.
Expand Down
2 changes: 1 addition & 1 deletion ...ether/Application/Dtos/PaginationLinks.cs → .../BBT/Aether/Pagination/PaginationLinks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace BBT.Aether.Application.Dtos;
namespace BBT.Aether;
Copy link

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The namespace BBT.Aether does not align with the file's directory structure, which is BBT.Aether.Core/BBT/Aether/Pagination/. It's a common convention in C# to have namespaces match the folder hierarchy. Consider changing the namespace to BBT.Aether.Pagination for better code organization and discoverability. This would also align with the PR description mentioning a "pagination namespace".

namespace BBT.Aether.Pagination;


/// <summary>
/// HATEOAS pagination links for API responses.
Expand Down
Loading