Skip to content

Add tags to account opening workflow config #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilmaztayfun merged 1 commit into from
Dec 3, 2025
Merged

Add tags to account opening workflow config #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/Tasks/account-opening/get-data-from-workflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"account-opening",
"scheduled-payments",
"subprocess",
"trigger"
],
Comment on lines +7 to +12
Copy link

@gemini-code-assist gemini-code-assist bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The tags added seem to be copied from another task (trigger-scheduled-payments.json) and don't accurately describe this task's function. This task, get-data-from-workflow, is a GetInstanceDataTask (type 13) which fetches data from a workflow instance.

The current tags are misleading:

  • scheduled-payments: This task is generic and not specific to scheduled payments.
  • subprocess: This is not a SubProcessTask (which is type 14).
  • trigger: This task fetches data; it doesn't trigger anything.

Using incorrect tags can make it harder for developers to find and understand components. I suggest using tags that better reflect this task's purpose, such as get-data and workflow which are derived from its key.

  "tags": [
    "account-opening",
    "get-data",
    "workflow"
  ],

"attributes": {
"type": "13",
"config": {
Expand Down