Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -268,4 +268,7 @@ profile-*
# Security
.npmrc.local
auth.json
secrets.json
secrets.json

# AI folders
ai-docs/
4 changes: 2 additions & 2 deletions core/Extensions/account-opening/extension-user-session.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"key": "extension-user-session",
"flow": "sys-extensions",
"domain": "core",
"version": "1.0.0",
"domain": "core",
"flow": "sys-extensions",
"flowVersion": "1.0.0",
"tags": [
"system",
Expand Down
3 changes: 1 addition & 2 deletions core/Tasks/account-opening/get-data-from-workflow.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"type": "13",
"config": {
"domain": "core",
"flow": "account-opening",
"instanceId": ""
"flow": "account-opening"
}
}
}
2 changes: 1 addition & 1 deletion core/Tasks/account-opening/trigger-scheduled-payments.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"type": "14",
"config": {
"domain": "core",
"key": "scheduled-payments",
"flow": "scheduled-payments",
"version": "1.0.0"
}
}
Expand Down
27 changes: 27 additions & 0 deletions core/Tasks/contract/get-contract-documents.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"key": "get-contract-documents",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"contract",
"documents",
"http",
"get-list"
],
"attributes": {
"type": "6",
"config": {
"url": "http://localhost:3001/api/contract/get-documents",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL is hardcoded to localhost. This is not suitable for different environments (development, staging, production). It's better to retrieve this URL from a configuration source to allow for environment-specific endpoints.

"method": "POST",
"headers": {
"Content-Type": "application/json"
},
"body": {},
"timeoutSeconds": 30,
"validateSsl": true
}
}
}

23 changes: 23 additions & 0 deletions core/Tasks/contract/notify-document-approved.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"key": "notify-document-approved",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"contract",
"notification",
"direct-trigger",
"document-approved"
],
"attributes": {
"type": "12",
"config": {
"domain": "core",
"flow": "contract-approval-workflow",
"transitionName": "document-approved",
"body": {}
}
}
}

23 changes: 23 additions & 0 deletions core/Tasks/contract/notify-document-ready.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"key": "notify-document-ready",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"contract",
"notification",
"direct-trigger",
"document-ready"
],
"attributes": {
"type": "12",
"config": {
"domain": "core",
"flow": "contract-approval-workflow",
"transitionName": "document-ready",
"body": {}
}
}
}

27 changes: 27 additions & 0 deletions core/Tasks/contract/render-document.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"key": "render-document",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"contract",
"document",
"render",
"http"
],
"attributes": {
"type": "6",
"config": {
"url": "http://localhost:3001/api/contract/render-document",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL is hardcoded to localhost. This should be made configurable to support different environments. Hardcoding URLs makes it difficult to deploy and test the application in different stages.

"method": "POST",
"headers": {
"Content-Type": "application/json"
},
"body": {},
"timeoutSeconds": 30,
"validateSsl": true
}
}
}

22 changes: 22 additions & 0 deletions core/Tasks/contract/start-document-subprocess.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"key": "start-document-subprocess",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"contract",
"subprocess",
"start",
"document-process"
],
"attributes": {
"type": "14",
"config": {
"domain": "core",
"flow": "contract-document-subflow",
"body": {}
}
}
}

27 changes: 27 additions & 0 deletions core/Tasks/task-test/test-dapr-pubsub.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"key": "test-dapr-pubsub",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"dapr",
"pubsub",
"messaging",
"event"
],
"attributes": {
"type": "4",
"config": {
"pubSubName": "vnext-execution-pubsub",
"topic": "vnext.test.events",
Comment on lines +17 to +18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pubSubName and topic are hardcoded. While this is a test task, it's better practice to make these configurable to allow for flexibility in different test environments without changing the task definition.

"data": {},
"metadata": {
"priority": "normal",
"source": "task-test-workflow"
}
}
}
}

24 changes: 24 additions & 0 deletions core/Tasks/task-test/test-dapr-service-task.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"key": "test-dapr-service-task",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"dapr",
"service-invocation",
"microservice"
],
"attributes": {
"type": "3",
"config": {
"appId": "mockoon",
"methodName": "/api/api/task-test/dapr-endpoint",
Comment on lines +16 to +17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The appId and methodName are hardcoded. The appId especially should be configurable to allow targeting different services in different environments. Hardcoding these values limits the reusability and flexibility of this task.

"httpVerb": "POST",
"queryString": "",
"timeoutSeconds": 30
}
}
}

23 changes: 23 additions & 0 deletions core/Tasks/task-test/test-direct-transition.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"key": "test-direct-transition",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"direct-trigger",
"transition",
"workflow-communication"
],
"attributes": {
"type": "12",
"config": {
"domain": "core",
"flow": "task-test-subflow",
"transitionName": "complete-subflow",
"body": {}
}
}
}

22 changes: 22 additions & 0 deletions core/Tasks/task-test/test-get-instance-data.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"key": "test-get-instance-data",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"instance-data",
"workflow-communication",
"data-fetch"
],
"attributes": {
"type": "13",
"config": {
"domain": "core",
"flow": "task-test-subflow",
"extensions": []
}
}
}

27 changes: 27 additions & 0 deletions core/Tasks/task-test/test-http-items.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"key": "test-http-items",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"http",
"api",
"external-service"
],
"attributes": {
"type": "6",
"config": {
"url": "http://localhost:3001/api/task-test/list-items",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL is hardcoded to localhost. This should be retrieved from a configuration source to allow for different environments.

"method": "POST",
"headers": {
"Content-Type": "application/json"
},
"body": {},
"timeoutSeconds": 30,
"validateSsl": false
}
}
}

27 changes: 27 additions & 0 deletions core/Tasks/task-test/test-http-task.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"key": "test-http-task",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"http",
"api",
"external-service"
],
"attributes": {
"type": "6",
"config": {
"url": "http://localhost:3001/api/task-test/http-endpoint",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The URL is hardcoded to localhost. This should be made configurable to support different environments.

"method": "POST",
"headers": {
"Content-Type": "application/json"
},
"body": {},
"timeoutSeconds": 30,
"validateSsl": false
}
}
}

22 changes: 22 additions & 0 deletions core/Tasks/task-test/test-start-workflow.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"key": "test-start-workflow",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"start",
"workflow-initiation",
"new-instance"
],
"attributes": {
"type": "11",
"config": {
"domain": "core",
"flow": "task-test-subflow",
"body": {}
}
}
}

23 changes: 23 additions & 0 deletions core/Tasks/task-test/test-subprocess.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"key": "test-subprocess",
"version": "1.0.0",
"domain": "core",
"flow": "sys-tasks",
"flowVersion": "1.0.0",
"tags": [
"task-test",
"subprocess",
"fire-and-forget",
"background-task"
],
"attributes": {
"type": "14",
"config": {
"domain": "core",
"flow": "task-test-subflow",
"version": "1.0.0",
"body": {}
}
}
}

Loading
Loading