Skip to content

Fix: db_cleanup pool, error logging, cleanup unused vars#12

Merged
buzzkillb merged 1 commit intomainfrom
dev
Mar 17, 2026
Merged

Fix: db_cleanup pool, error logging, cleanup unused vars#12
buzzkillb merged 1 commit intomainfrom
dev

Conversation

@buzzkillb
Copy link
Copy Markdown
Owner

@buzzkillb buzzkillb commented Mar 17, 2026

Summary

  • db_cleanup now uses shared connection pool instead of opening its own connection
  • Log errors in aggregation instead of silently using fallback values
  • Remove unused variables (_effective_start in health.rs, DATABASE_PATH import)

Changes

  • DatabaseCleanup accepts Arc and uses its connection pool
  • Aggregation errors are now logged with warn! instead of silently falling back
  • Removed unused _effective_start variable in health.rs
  • Removed unused DATABASE_PATH import in db_cleanup.rs
  • Fixed unused start_time variable warning

Note

Low Risk

Overview
This pull request makes three main improvements: refactors db_cleanup to use a shared connection pool from PriceDatabase instead of creating its own connection, adds proper error logging in the aggregation logic using warn! instead of silently falling back to default values, and removes unused variables including _effective_start from health.rs and the unused DATABASE_PATH import.

Written by Gitzilla for commit f9ec38a. This will update automatically on new runs. Configure in the Gitzilla dashboard.

@buzzkillb buzzkillb merged commit 8541d44 into main Mar 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant