fix: resolve .env path with fallback chain (#16)#17
Open
Conversation
…name (#16) The .env path was hardcoded to __dirname/../.env which points inside node_modules for global npm installs, so servers were never found. Now searches: SSH_ENV_PATH env var → cwd/.env → ~/.env → __dirname/../.env Also awaits configLoader.load(), initializeHooks() and loadToolConfig() to fix race condition where MCP server started before config was loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16 — SSH servers not loaded when installed globally via npm.
.envpath resolution: Replace hardcoded__dirname/../.envwith a fallback chain:SSH_ENV_PATHenv var →cwd/.env→~/.env→__dirname/../.envconfigLoader.load(),initializeHooks(), andloadToolConfig()are now properlyawaited instead of using fire-and-forget.then(), ensuring config is fully loaded before the MCP server starts respondingenvFilePathis now logged at startup for easier troubleshootingTest plan
.envin~is found.envin project root is still found (backward compat)SSH_ENV_PATH=/custom/path/.env: verify explicit override works