Conversation
|
I have already addressed this in PR #625. I'm not going to review and approve a duplicate PR. |
@tbooth This is not a duplicate PR, there is some overlap, but PR #325 is using |
|
@kingbuzzman you are clearly working from a different set of guidelines than I am seeing. I'm following the setuptools user guide: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html Where are you getting your info from, please? |
|
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html From my own tests (see CI) it works with 3.6+, the is that when you do |
|
I still don't see how keeping any |
only for 3.6 See this script for python rm -f setup.py # This is why setup.py is neeeded!!!! Note we are deleting it here
scripts=(
"pip install ."
"python setup.py install"
"pip install -e ."
"pip install -e '.[test]'"
)
for script in "${scripts[@]}"; do
echo "==== Running: $script ===="
docker run -it --rm -w /app -v "$(pwd)":/app python:3.6 bash -c "$script"
doneoutput: Note: the only if we run the EXACT script in Note: only the now if we remove the Here is Here is Note that both 3.6 and 3.7 work as expected on their "normal runs" |
|
@tbooth For reference, I checkout'ed your branch and ran the same script, and it passed... well, all but the
here is your PR's output: |
Please squash
Tangentially related to #325