PR #2 - Migrate: Totem TCP -> gRPC client and EventStoreDB 20.10 -> 24.10+#95
Open
AlexanderJohnston wants to merge 22 commits into
Open
PR #2 - Migrate: Totem TCP -> gRPC client and EventStoreDB 20.10 -> 24.10+#95AlexanderJohnston wants to merge 22 commits into
AlexanderJohnston wants to merge 22 commits into
Conversation
- Write to the client stream whether or not the checkpoint write succeeds - Do not ignore events routed to stopped flows - Avoid a null reference when an existing flow fails to load
The SkipException handling that required await was removed in a prior commit. Simplify back to returning the task directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AlexanderJohnston
force-pushed
the
feature/grpc-Cleanup
branch
from
82e1c78 to
df36740
Compare
AlexanderJohnston
changed the title
AlexanderJohnston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflict Resolution
Notes and justification for you.
ClientDb: In the old TCP client, e.Event.Data was a byte[]. In the new gRPC client, it's a ReadOnlyMemory. The FromJsonUtf8 method and MemoryStream constructor both expect byte[], so .ToArray() is needed to convert from ReadOnlyMemory to byte[].
TimelineDb: I believe this WriteResult type was made into an interface at some point but I couldn't track down when.
Summary
Migrates Totem.Timeline.EventStore from the legacy TCP-based EventStoreDB client (EventStore.ClientAPI.NetCore v4.1.0.23) to the gRPC client (EventStore.Client.Grpc.Streams + EventStore.Client.Grpc.ProjectionManagement v23.3.9).
Required because EventStoreDB 24.10+ dropped TCP protocol support.
Implementation
Migration Strategy For Existing Consumers