Skip to content

fix: stabilize annotation CLI integration#21

Merged
byemaxx merged 2 commits into
devfrom
fix/annotation-cli-integration-contract
Jul 15, 2026
Merged

fix: stabilize annotation CLI integration#21
byemaxx merged 2 commits into
devfrom
fix/annotation-cli-integration-contract

Conversation

@byemaxx

@byemaxx byemaxx commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • pass multiple MetaUmbra digest directories through its actual single-value delimiter contract
  • make global genome-selection inference and validation consistent across CLI and GUI
  • resolve configuration-file paths relative to the configuration file while preserving CLI override semantics
  • preserve existing scientific outputs by selecting a collision-free actual output path, while atomically replacing the requested result JSON
  • terminate subprocess trees on cancellation and retain the CLI exit-130/result contract
  • expand installation-profile CI coverage, including Windows annotation integration tests

Root cause

The integration layer previously treated MetaUmbra digest directories like repeated argv values even though MetaUmbra accepts one delimited value. Selection inference, metadata, config-relative paths, output collisions, and subprocess cancellation were also handled in separate places, which allowed contradictory or incomplete behavior.

Compatibility and impact

  • No peptide mapping, LCA, intensity, aggregation, or other scientific calculation method was changed.
  • The annotation result schema remains 2.0 and the workflow API remains 1.0.
  • This intentionally cleans up contradictory selection configurations rather than preserving them.
  • No IterDIA-specific code or README documentation is added.

Validation

  • 117 passed, 2 warnings in the focused annotation/integration suite
  • 324 passed, 31 warnings in the complete local test suite
  • real MetaUmbra parser verified with multiple digest directories containing spaces
  • lightweight/base import verified without PyQt
  • GitHub Actions workflow YAML parsed successfully
  • git diff --check passed

@byemaxx

byemaxx commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af34db97d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +18 to +19
if process.poll() is not None:
return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid returning before killing the process group

When cancellation happens after the process-group leader has exited but its descendants are still alive (for example a helper that spawned digested-scan workers which keep stdout open), this early return skips os.killpg(...) even though run_streaming_subprocess starts the command in a new session. In that state the CLI can report cancellation while orphaned worker processes continue running; for process_group=True, attempt to terminate the group even if poll() says the direct child is already gone.

Useful? React with 👍 / 👎.

@byemaxx
byemaxx marked this pull request as ready for review July 15, 2026 15:59
@byemaxx
byemaxx merged commit 4c2a017 into dev Jul 15, 2026
6 checks passed
@byemaxx
byemaxx deleted the fix/annotation-cli-integration-contract branch July 15, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant