Skip to content

Unify MetaUmbra manifest annotation workflow#22

Merged
byemaxx merged 5 commits into
devfrom
refactor/unified-metaumbra-manifest
Jul 19, 2026
Merged

Unify MetaUmbra manifest annotation workflow#22
byemaxx merged 5 commits into
devfrom
refactor/unified-metaumbra-manifest

Conversation

@byemaxx

@byemaxx byemaxx commented Jul 15, 2026

Copy link
Copy Markdown
Owner

What changed

  • Add a strict loader for metaumbra.genome_selection_manifest.v1 and one manifest-driven OTF backend for single- and multi-unit annotation.
  • Keep explicit non-MetaUmbra sources: MetaX automatic genome selection and custom genome lists.
  • Preserve custom intensity prefixes and correct automatic/custom-list provenance.
  • Keep analysis_unit_id in canonical manifest OTF output, including __global__.
  • Reorganize the Peptide Annotator GUI around source, inputs, validation, output, and advanced settings.
  • Validate empty threshold genome lists and make Windows console progress output encoding-safe.
  • Update CLI/result JSON, workflow recorder, documentation, cross-repository contract tests, and GUI/backend tests.

Why

The earlier implementation inferred modes across separate global and unit-specific paths. That duplicated scientific behavior, produced inconsistent downstream schemas, and caused regressions in non-manifest annotation settings.

Impact

MetaUmbra-driven annotation now consumes the unified manifest contract. Existing MetaX automatic and custom-list annotation remain supported through explicit source selection.

Validation

  • Annotation/analyzer/workflow regression selection: 75 passed
  • Final manifest, CLI, backend, GUI-layout, console, and cross-repository focused suite: 23 passed
  • Real global OTF: 29,437 rows with analysis_unit_id=__global__
  • Real three-unit OTF: 84,390 rows, no duplicate (analysis_unit_id, Sequence)
  • Real automatic and custom-list runs validated with an Abundance intensity prefix
  • git diff --check passed

@byemaxx

byemaxx commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb54007fcf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_peptide_annotator_layout.py
@byemaxx
byemaxx marked this pull request as ready for review July 19, 2026 16:13

byemaxx commented Jul 19, 2026

Copy link
Copy Markdown
Owner Author

Ready to merge.

The review feedback and follow-up hardening are complete:

  • initialized QApplication before constructing GUI widgets;
  • made manifest loading strictly validate required fields, list types, uniqueness, and threshold relationships;
  • added fail-fast checks for missing or duplicate selected genome TSV files without rereading TSV contents;
  • added the pinned MetaUmbra producer contract test to CI.

Validation at head 256af84:

  • focused/regression suite: 102 passed;
  • GitHub Actions: 6/6 passed;
  • all review threads resolved;
  • merge state: CLEAN.

The added runtime work is limited to linear validation of manifest metadata and already-enumerated file names, so no meaningful annotation-performance regression is expected.

@byemaxx
byemaxx merged commit 7a98d6b into dev Jul 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant