Unify MetaUmbra manifest annotation workflow#22
Merged
Conversation
Owner
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb54007fcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
byemaxx
marked this pull request as ready for review
July 19, 2026 16:13
Owner
Author
|
Ready to merge. The review feedback and follow-up hardening are complete:
Validation at head
The added runtime work is limited to linear validation of manifest metadata and already-enumerated file names, so no meaningful annotation-performance regression is expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
metaumbra.genome_selection_manifest.v1and one manifest-driven OTF backend for single- and multi-unit annotation.analysis_unit_idin canonical manifest OTF output, including__global__.Why
The earlier implementation inferred modes across separate global and unit-specific paths. That duplicated scientific behavior, produced inconsistent downstream schemas, and caused regressions in non-manifest annotation settings.
Impact
MetaUmbra-driven annotation now consumes the unified manifest contract. Existing MetaX automatic and custom-list annotation remain supported through explicit source selection.
Validation
analysis_unit_id=__global__(analysis_unit_id, Sequence)Abundanceintensity prefixgit diff --checkpassed