Skip to content

Fix Oracle SQL*Plus command splitting#138

Merged
rebelice merged 1 commit into
mainfrom
codex/oracle-sqlplus-command-split
May 13, 2026
Merged

Fix Oracle SQL*Plus command splitting#138
rebelice merged 1 commit into
mainfrom
codex/oracle-sqlplus-command-split

Conversation

@rebelice
Copy link
Copy Markdown
Collaborator

Summary

  • Preserve real Oracle SQL SET statements such as SET TRANSACTION, SET ROLE, and SET CONSTRAINT(S) as SQL segments.
  • Avoid misclassifying SQL continuation lines like START WITH, CONNECT BY, CONNECT TO, and SET DEFAULT as SQL*Plus commands.
  • Allow unambiguous SQLPlus commands, including PROMPT, SPOOL, SET DEFINE, SET DEF, SET SERVEROUT, and SQLPlus CONNECT, to terminate buffered SQL safely.

Test Plan

  • go test ./oracle/parser -run 'TestSplitClassifiesUnambiguousSQLPlusCommandsAfterBufferedSQL|TestSplitDoesNotClassifySQLContinuationLinesAsSQLPlus|TestSplitClassifiesOracleSetStatementsAsSQL|TestSplitSQLPlusCommands|TestSplitClassifiesSQLPlusCommands' -count=1
  • go test ./oracle ./oracle/parser -count=1
  • git diff --check

@rebelice rebelice merged commit 4545f7a into main May 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant