-
Notifications
You must be signed in to change notification settings - Fork 95
feat(preview2-shim): implement browser HTTP fetch support via JSPI #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vados-cosmonic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic work @danbopes , thanks for contributing so much implementation to the browser preview2-shim, it has not gotten any attention for a long time.
I have a few nitpicks/small changes proposed, please take a look and let me know if you have any questions/disagree!
|
Hey @danbopes thanks for your hard work here and iterating so fast and explaining stuff to me where necessary. If I can ask for one more thing -- can you either format your commits to match the conventional commits standard or squash to one commit with a title like the following: The tagging is picked up by the automation in-repo, and we don't squash actually -- we fast-forward so that we can (easily) catch non-conforming commit titles in CI |
|
@vados-cosmonic Done |
|
🎉 The code in this PR was made available in the following release: |
Implement the browser WASI HTTP shim using the fetch() API with JSPI for async suspension, replacing the previous non-functional stubs.