feat(bindgen): add semver-compatible matching #1252
Merged
+387
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks for landing this @ricochet !
Code looks good to me, would you mind adding an E2E test that makes sure this does what it's supposed to from the user point of view?
packages/jco/test/cli.js is not a bad spot I think
vados-cosmonic
force-pushed
the
feat/semver-map
branch
2 times, most recently
from
605a536 to
6ee8664
Compare
Support semver compatibility when resolving import map entries. If no exact or wildcard match is found, fall back to matching map entries on the same semver compatibility track, preferring the highest compatible version.
vados-cosmonic
force-pushed
the
feat/semver-map
branch
from
6ee8664 to
875531a
Compare
vados-cosmonic
approved these changes
Feb 11, 2026
vados-cosmonic
force-pushed
the
feat/semver-map
branch
from
9421c02 to
52a4026
Compare
Merged
via the queue into
bytecodealliance:main
with commit Feb 11, 2026
139e484
67 of 69 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support semver compatibility when resolving import map entries.
If no exact or wildcard match is found, fall back to matching
map entries on the same semver compatibility track, preferring
the highest compatible version.