Implement socket_bind_device and set_socket_bind_device#1426
Open
al8n wants to merge 2 commits intobytecodealliance:mainfrom
Open
Implement socket_bind_device and set_socket_bind_device#1426al8n wants to merge 2 commits intobytecodealliance:mainfrom
socket_bind_device and set_socket_bind_device#1426al8n wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
Member
|
It looks like this has a build error in the tests on non-Linux platforms: Can we enclose those tests in |
|
I'm interested in this feature. @al8n are you still working on it? |
Contributor
Author
I almost forget this PR. But I will update the code this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds
socket_bind_deviceandset_socket_bind_devicemethods.Besides, as the interface name can only be
[u8; 16], I think adding anInterfaceBufferis better, so that we can remove theallocfeature, which has been mentioned in #1393 and #1397 previously.