Clobber vector registers and do not use preserves_flags in riscv64 syscalls#1570
Open
taiki-e wants to merge 1 commit intobytecodealliance:mainfrom
Open
Clobber vector registers and do not use preserves_flags in riscv64 syscalls#1570taiki-e wants to merge 1 commit intobytecodealliance:mainfrom
taiki-e wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From kernel docs: https://docs.kernel.org/arch/riscv/vector.html#vector-register-state-across-system-calls
And the linked docs says:
See also this glibc bugfix: https://patchwork.sourceware.org/project/glibc/patch/18a15d9d-e3d0-4625-a49e-03e3ecddf011@tenstorrent.com/
(Probably musl (riscv64, riscv32) also has the same bug. cc @Amanieu @kraj as target maintainers of corresponding Rust targets)
Unlike the above glibc patch which clobbers them depending on whether the vector ISA is enabled, this patch always clobbers them. (
cfg(target_feature = “vector”)does not work except on nightly because thevectortarget feature is unstable. And, in Rust, always marking them as clobbered works fine (as clobber_abi does).