Support for native AOT & static linking#348
Open
andrewmd5 wants to merge 4 commits intobytecodealliance:mainfrom
Open
Support for native AOT & static linking#348andrewmd5 wants to merge 4 commits intobytecodealliance:mainfrom
andrewmd5 wants to merge 4 commits intobytecodealliance:mainfrom
Conversation
the project is configured to always download the pre-release version of wasitime outside of a publish workflow - 'dev' has breaking changes. This resolves them and bumps to 38.0.3
Author
|
CC: @peterhuene & @jsturtevant |
Contributor
Personally I would like to keep keep .NET Standard 2.1 support until Unity supports CoreCLR, after that I wouldn't have a usecase for it. Anyone stuck using .NET Framework would probably want it kept beyond that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives consumers of wasmtime-dotnet the ability to statically link the native libraries into their executable when publishing with AOT compilation.
I also added all the necessary attributes on the reflection codepaths.
produces:
My recommendation would be to drop support for .NET Standard 2.1 to take advantage of static abstract members in interfaces to avoid using things like Activator.CreateInstance - and introduce a source generator to to remove all dependencies on reflection. But for my use-case this PR is sufficient and unblocks me.
Resolves #293