Make dev vs stable ABI layouts conditional on DevBuild#352
Closed
tomohisa wants to merge 1 commit intobytecodealliance:mainfrom
Closed
Make dev vs stable ABI layouts conditional on DevBuild#352tomohisa wants to merge 1 commit intobytecodealliance:mainfrom
tomohisa wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Author
|
Superseded by #355. The DevBuild ABI toggle is included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WASMTIME_DEVdefine whenDevBuild=true.Why
Dev snapshots changed ABI/TrapCode; stable 35.0.0 expects the older layout. This avoids mismatches.
Tests
dotnet test tests/Wasmtime.Tests.csproj -c Release -p:DevBuild=truedotnet test tests/Wasmtime.Tests.csproj -c Release -p:DevBuild=falseNotes
If switching DevBuild modes, you may need to delete
src/objto force re-download of C API artifacts.Risk
Medium. Changes are behind build-time flags and default to current dev behavior.