Fix stdin/stdout/stderr not being replaceable#1839
Closed
linouxis9 wants to merge 1 commit intobytecodealliance:masterfrom
linouxis9:master
Closed
Fix stdin/stdout/stderr not being replaceable#1839linouxis9 wants to merge 1 commit intobytecodealliance:masterfrom linouxis9:master
linouxis9 wants to merge 1 commit intobytecodealliance:masterfrom
linouxis9:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OsOther cannot be used for file descriptors representing a file or a directory.
wasmtime/crates/wasi-common/src/sys/unix/osother.rs
Line 16 in 4bb5894
As such, an OsFile should instead directly be used.
Before this PR, and since #1561, it was not possible to replace stdin/stdout/stderr with an user-provided File.