This repository was archived by the owner on Dec 26, 2024. It is now read-only.
Fix/calculation error#18
Open
LinXiaoTao wants to merge 3 commits intobytedance:masterfrom
LinXiaoTao:fix/calculation_error
Open
Fix/calculation error#18LinXiaoTao wants to merge 3 commits intobytedance:masterfrom LinXiaoTao:fix/calculation_error
LinXiaoTao wants to merge 3 commits intobytedance:masterfrom
LinXiaoTao:fix/calculation_error
Conversation
|
发现如果外层设置了 padding,还是会有问题 |
Author
|
@2dxgujun 看下我最新提交的。 |
Author
if (textOffset == 0) {
offsetForCaret = Offset(0, offsetForCaret.dy);
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when ImageSpan is the first span, dx calculation error.
当 ImageSpan 作为第一个 span 时,dx 看起来计算不对,会遮挡后面的 span。
修复之前:

修复之后:

可能原因:
问题出在以下这些代码:
当 textOffset = 0 时,也就是第一个 span 是 ImageSpan,dx 应该等于 0,当调用
getOffsetForCaret()后,offsetForCaret.dx大于 0,所以导致第一个 ImageSpan 绘制到后面的 span 上了。