This repository was archived by the owner on Jul 21, 2025. It is now read-only.
support ipv6#39
Open
algs wants to merge 4 commits into
Open
Conversation
pleasantrabbit
left a comment
pleasantrabbit
left a comment
There was a problem hiding this comment.
please check the comment on the log message. everything else looks good to me.
| if (n > 1) { | ||
| CHECK(!zmq_setsockopt(receiver_, ZMQ_IPV6, &option, sizeof(option))) | ||
| << zmq_strerror(errno); | ||
| PS_VLOG(1) << "bind with ipv6 socket with host " << hostname; |
There was a problem hiding this comment.
"bind IPv6 socket to host " would be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.